Construction point labelling

[Douglas]

@Evans

it also allowed me to discover the code of the software and have a grasp on the way it works, so only for that it was really useful for me.

I get it… keep in mind though the code is way more complex than you might think. Nothing is easy. I’ve been working with the code for more than 5 years and only now do I know how much I don’t know.

@Evans

Speaking of the code, I was wondering what was the meaning of all the “v” prefixes in the directories (vtools, vgeometry, vformat etc.)

Well… it’s one of the annoying points with me. The original app that Seamly forked from was called Valentina, and the original dev for what ever stupid reason prefaced every class and file name with V. very annoying. I’ve slowly been renaming and removing the V’s as I update the app.

@Evans

I can definitely try to implement this basepoint combobox if I’m not interfering with other features in progress, and if it can be of some help

Certainly go ahead… that’s why I kinda outlined what I’d do.

@Evans

My only worry about this feature is that the letters that people seem to use when adding those construction points are close to the end of the alphabet to better distinguish them from the other letters. I fear it will still be not really practical to have to scroll into the combobox each time the user wants to use another letter for construction purposes, this is why I was more gowing towards the idea of “construction points”.

You make the combobox entry “editable” so a user can just type in the letter. They don’t have to scoll if they know what letter they want. You can also choose to sort the combobox items.

comboBox->model()->sort(0, Qt::DescendingOrder); // default Qt::AscendingOrder

@Evans

But if the point name field could automatically suggest the next available number it would solve the problem without the need of this construction point functionnality. Maybe the point name field could autocomplete the next available number if the tab key is pressed ? Like I’m entering X then tab and it automatically writes X2 if it is available?

But you have to get the “next” base letter from somewhere. You want it dynamic and not just a generic X. Again… look at the Pen Toolbar and Attributes in the diialogs. That’s exactly what is happening… the PenToolbar initially reads the settings… then any time a new tool is created and the initial dialog opens it “autocompletes” the attributes with the Pen settings. Change the toolbar… it changes the default Pen Attributes. In the case of the Pen Toolbar you can also save the current Pen or at anytime Reset to the last saved Pen.

@Evans

But it will still require a modification of every dialog and property editors… But wouldn’t it be also the case if, as you suggested, we integrate the basepoint combobox into the tool dialogs like the pen toolbar?

@Evans

But it will still require a modification of every dialog and property editors… But wouldn’t it be also the case if, as you suggested, we integrate the basepoint combobox into the tool dialogs like the pen toolbar?

Yes… on the dialogs. No on the Property editor. Refer to my first response. The Property Editor has nothing to do with creating a new Tool… only editing an existing one.

@Evans

But I have quite a lot of issues like the one you mention with other dialogs, for instance with the “export layout” dialog which is crushed at the top :

I will take a look at it.

@Evans

Of course, I would be happy to help ! I started translating approximately half of the seamly2d_fr_FR.ts today, I’ll continue in the next days, I keep you informed. Here’s the branch I use for the translation :

Excellent. Just a note… any translations also have to pass the translations tests to make it pass the CI workflow. There’s a lot of DO and DONT’s with the translations. I outlined a bunch in this topic:

German translation for Seamly to be continued

@Douglas, thanks in advance.