Default notch settings not functioning

[Pneumarian]

On Devuan Linux & Chromebook VM Debian Linux. Tested on 20260713 & 20250804 (Qt5)

The Gist:

1. The Piece Point context menu defaults to deactivating notches.
2. The Default Notch Preference appears to be entirely dysfunctional.
3. I’d prefer that the Default Notch be restored to function rather than deprecated. But the notch-eating bug is a bug.

The Meandering:

While the context menu is nice in that I don’t have to open the properties dialog, & mess around, it is annoying that I have to select the attributes of the notch I’m adding. Doubly so since there used to be a working default notch setting, which no longer seems to have any effect, but still resides in the Preferences dialog.

I noticed this most recently when trying to uncheck a notch (for Science!) & the checkbox flickered but nothing changed until I closed the context menu. Then the notch disappeared. When I tried to click the checkbox in the context menu again to turn it back on, again there was a flicker, (or was it the checkbox shaded?) but nothing happened without navigating down the three levels of notch context menu.

With further prodding, I see the notch de-rendering every time the context menu is exited without performing an operation.

[Douglas]

@Pneumarian

While the context menu is nice in that I don’t have to open the properties dialog, & mess around, it is annoying that I have to select the attributes of the notch I’m adding. Doubly so since there used to be a working default notch setting, which no longer seems to have any effect, but still resides in the Preferences dialog.

Yes I see your point… I’ll have to see if I can have it select the main menu Item “Notch”, without having to set the type/ subtype & count… and have it use the default prefs.

OR

Have the context menu just show “Notch” with no subitems IF the node point is NOT a notch - and use th edefault prefs… and if it is a Notch show the subitems so you can edit the notch.

[Douglas]

Hey @Pneumarian

What if I add a Notch->Default item above Notch->Type… does that work for you? Would be much easier to implement.

[Pneumarian]

That would not be ideal, but it’s a fair compromise

However, I wonder if having it as a separate root context-menu item to turn-on/off the notch, & change the current “Notch” to “Customise Notch” without the checkbox would eliminate the code which generates the notch-eating bug. Of course, that might cause other problems I’m not anticipating.

[Douglas]

@Pneumarian

However, I wonder if having it as a separate root context-menu item to turn-on/off the notch, & change the current “Notch” to “Customise Notch”

How about:

 x Show Notch
   Set as Notch  //With default settings
   Edit Notch >
         Type >
      Subtype >
        Count >

Selecting Set as Notch or Edit Notch sets Show Notch to True as one would think if you are setting or editing the notch you want to see it.

@Pneumarian

Of course, that might cause other problems I’m not anticipating.

That should eliminate any problems.

[Pneumarian]

I think that will work great

[Douglas]

It’s pretty straight forward too… hardest part will be updating the translations.

[Douglas]

Here it is in… context.

This will work so much better as besides restoring the default notch prefs it separates the visibilty of the notch from the attributes.

[Douglas]

Fixed showing the correct state of the custom checked icon:

Below - Point name shows, notch is hidden.

Removed the type “None” as being moot with the “Show Notch”:

[Douglas]

Ok here’s a question for the users.

Does anyone see any use to be abe to set the color per notch rather than the singe global color for all notches?

[Grace]

@Douglas

Does anyone see any use to be abe to set the color per notch rather than the singe global color for all notches?

Personally, I like the notches to be the same colour as the cut line, and attached to the cut line

[Pneumarian]

@Douglas

Ok here’s a question for the users.

Should we "@everyone" this?

[Douglas]

@Grace

I like the notches to be the same colour as the cut line

@Pneumarian

Should we "@everyone" this?

I should probably rephrase the question:

Are there any users that would like to be able to set the color of individual notches?

Being able to set the color of an individual notch would not prevent one from setting the color the same as the cut line.

@Grace

and attached to the cut line

That’s a separate issue and more related to exporting pieces where I should look at being able to export the cutline and / or seamline and the notches as a group. Currently the cutline, seamline, and notches are exported as separate paths.

[Douglas]

Pattern Piece Dialog → Main Path context menu updated:

Unless anyone has any other suggestions I think this will have addressed the issue, and all I need to do now is update the translations.

[Douglas]

Actually I’ve discovered another anomaly that needs to be fixed:

When you use the “built in” option it disables the SA and what was the seam line becomes the cutline. If you have a notch and uncheck both Show notch on cutline and Show notch on seamline… it has no effect and the notch remains visible.

I think may also change the context menus to:

x Show Notch on Cutline      // toggle the node "showNotch" attr
x Show Notch on Seamline     // toggle the node "showSecondNotch" attr
  Make Default Notch         // Set "notch" = true with default attributes 
  Edit Notch                 // Edit notch attributes
  Remove Notch               // Clears notch attributes from node

This also fixes another issue in the Pattern Piece Dialog context menu in that the “Show Notch” item was toggling the node “notch” attr… which the Set as Notch was also doing, but with the default settings… Except with a new piece you could select Show Notch which was redundant with Set as Notch. The Show Notch had the effect of showing or hiding the notch as it literally was setting or unsetting the node as a notch.

The above changes will separate the “visibilty” of the notch on either path from the making a node a notch or not. So the Make Default Notch acts as making a node a notch for the 1st time OR resetting a notch to the default settings.

In theory the Show Notch on Cutline and Show Notch on Seamline items should only be enabled IF the node is a notch (“notch” = true)… otherwise they should be disabled and greyed out. And Show Notch on Seamline should also only be enabled IF the piece SA is NOT “Built in”.

[Douglas]

Updated node context menu:

Disables the “Edit Notch” menu item if it’s NOT a notch as you can’t edit it if it’s not a notch.

Also “Show Seamline Notch” is disabled if Seamline is Hidden or SA is built In.

Just have to fix this issue where if SA is Built In and Show Cutline Notch is toggled off… the notch should be hidden.

Which means digging into my favorite part of the code… the Pattern Piece Tool.

[Douglas]

Aha Success!

Toggling off Show Cutline Notch when SA is Built IN now hides notch:

Also one more slight addition… added the “red” icon to indicate the Show Seamline Notch menu item is disabled (rather than just being turned off) when the SA is Built in or Hide Seamline is checked.

Now I can update the Pattern Piece Tool → Main Path context menu again, and then the translations and this issue will be done.

[Douglas]

Context menu updated in the Pattern Piece dialog… also added the disabled icon to the Show Cutline Notch if the node is not a notch. Again… can’t select Show Cutline Notch if it’s not a notch.

lupdate here we come.

[Douglas]

Feature / Fix all merged. Should be in next weeks release.

[Pneumarian]

Initial tests are looking good. I’ve had reason to adjust my default notch lengths! Thank you soooo much