I’ll probably upload the changes later today… just cleaning up - um refactoring the gawd awful Hungarian Notation naming conventions used in the Text Labels & Grainline widgets. For the life of me I don’t know why anyone in their right mind would use that in modern day C++. The code is hard enough to read through without having to deal with that on top of bad abbreviations - like pME or fH and fW… instead of event, height and width. Or instances like bShort == true instead of just isShort.
In case anyone is wondering what Hungarian Notation is… it’s a naming convention where the data type prefixes all the variable names - p for pointer, i for int, f for float, d for double, b for boolean, qs for QString, etc etc etc. It can be a nightmare to decipher.
Debatable. Regardless… it’s not the style of this project. And there in lies the problem… no one was maintaining any consistency in style. Considering Qt is the framework - IMO that’s the style the the project should follow - which is certainly NOT Hungarian notation.
As a consequence of testing this issue, I came across again a long standing issue in regards to the rotation of the pattern “piece” label. When trying to interactively rotate it, once you release the mouse the label returns to it’s original rotation. I fixed the issue and made a PR.
Anyhow… I added the line weight option to the grainlines. The default is set to 0.25 mm, which when scaled by a factor of 3 (which I did to get a wider range of sizes for the grain lines), approx yields the current line width of 3 pixels.
and the max of 2.11mm yields this:
Also fixed the arrow heads when using “Text as paths” to not have the leader line going through the head(s).
Unless you select “Text as Path” in the layout settings, in which case only the outline (path) or the arrow heads are exported. I just used the same checkbox state to determine how the text and arrowheads export. Granted the terminology should probably change to something more inclusive like “Graphic objects as path”… even more so once I introduce symbols.