New fx Editor feature

While watching @Grace working on a pattern during the Pattern making Zoom session, I noticed something we’re always having to do when inserting angles of lines… we need to add or subtract 180 deg to get the angle of the line flipped, or need to add or subtract 90 deg to rotate the angle… so I thought to improve the workflow we can automate the process. For the Line Angle and Curve Angle tabs I added an fx-90, an fx+90, and fx-180, and and fx+180 insertion button. So now if you want to add 180 to say line angle AngleLine_A100_A104, you just click the fx+180 and it inserts “(AngleLine_A100_A104 + 180)”

I also moved the “Hide empty measurements” checkbox next to the Filter box where it makes more sense. I aso made the hide checkbox only show when the Measurements tab is selected, rather than greying it out for all the other tabs.

8 Likes

Oh, wow!!! @Douglas , you’re really, really a :star:

Thank you very much, I didn’t even think of asking for that.

2 Likes

I didn’t think of it either until Iwas watching you using the fx editor. :slightly_smiling_face:

I think something else that may be of use is to add another column to display the value of the variables.

2 Likes

Done. I added a value column to the fx Editor so it now displays the value of all the variables except the Functions which don’t have a value.

Going to try and have the Value header item that adapts to show the units like in the Variables table.

There is one slight anomaly in the Variables table - you could have a Custom Variable or Custom Measurement that represents an angle, and not a length. There’s no way to deduce from a VarType::Measurement or VarType::Variable if it’s legth or angle… unlike the other VarType’s. For ex: if the VarType is VarType::LineLength, we know it’s a length and can say it’s units are (cm) or (inch).

I’m curious as to whether any user has actually used a custom measurement or variable that is an angle value?

3 Likes

Custom measurement as angle, yes, that’s possible where one shoulder is more sloped than the other.

Variables, no, Since you can use line lengths and angles in a variable, I don’t think it will really come up, although I have used it with a Function formula.

1 Like

Here’s an example of what I mean that some could do…

and another example where I actually do use a variable as bezier curve constant - it has no units.

image

What I’m saying is that a Custom Variable could have any defined type of unit or no unit at all, which may not fit the Calculated Value header type of “length” (in the current pattern units of cm or inch). IMO how the Variables Table and FX Editor should display for Custom Variables is no units in the header, and units after each cell item value. That would require adding a "units’ member to the custom_variable class or vinternalvariable base class.

Which BTW…I did add the Value units postfix in the headers…

4 Likes

I think that “Value” without units should be more than sufficient.

2 Likes

I often use degree and percentage in the customer variables. Degree for shoulder angle, butt angle, hip curve angle and also for bust darts. Percentage for dart length, sleeve head height etc etc. Honestly i do not care if in the header something mentioned.

Btw It is a great idea to display the value in the fx-editor. The value was only visible on click

3 Likes

Upon request I added buttons for ± 45 degs… and there’s a PR pending, so this should show up soon.

image

5 Likes