Search Featurin Drafting

It would be great if you could put the “Number” (H05, I01 e.g.) in the dialog box that pops up with your measurements when you are drafting so that you can search by it instead of having to type in, let’s say, neck and pull up 6 items to still have to look through.

Thank you.

2 Likes

I think it’s been discussed somewhere before, but there’s never been a formal issue added to Github. I’ve made a note to do so. :slight_smile:

It should be relatively easy to add the “Number” column in the fx editor for the measurements, thus making the Numbers searchable.

2 Likes

Thanks Douglas, that would be great!

1 Like

Done. I added a (diagram) number column. Number data is included in the search filter. I also increased the minumum dialog width to 750 px.

image

Custom measurements show as “na” or not applicable.

image

2 Likes

Thank you very much, @Douglas :star_struck:

Edit: Is it possible to set the minimum width to quite a bit less? Then one can drag the width wider or narrower according to what one wants to see? Perhaps a scroll bar at the bottom to scroll across if one wants to see anything else?

And then… :grin: Is it at all possible to have an option to view the image of the measurement area when one clicks on the (diagram) number line (similar to the one in SeamlyME)?

Perhaps have a “Show Diagram” checkbox at the top to the right of the “Hide Empty Measurements” checkbox.

Something like this:

Some of the measurement areas appear very similar to others in words, so I think something like this will help beginners to identify the correct measurement.

1 Like

Yes… but then it does this with the last column eliding… and you’re going to get tired of having to resize the dialog everytime. All I did was add 100px to account for adding the Number col.

image

It’s also difficutlt to size the headers (col width) in a table. So the best tradeoff is: currently columns are set to a minimum width of 70px to hold the “Number” col. Then the attribute resizeColumnsToContents() is set so columns will at least exapand to hold the contents without eliding… such as arm_shoulder_tip_to_wrist_bentn the last option is the last column is set to setStretchLastSection(true) so the last colum will sretch when the window is resized larger - without affecting the other columns.

If you don’t set the last column to stretch, then all the columns stretch when you resize and it looks crappy.

The Table is already in a scrollbox… but apparently the horizontal one is disabled by the fact the col width is set to contents & last col stretched - even if the option horizontalScrollBarPolicy is set to ScrollBarAlwaysOn (I usally set the scroll policy to ScrollBarAsNeeded).

You know… I thought of that, and then thought it would just be overkill. :grin:

There’s also the issue that it may prove difficult to access the diagrams in SeamlyMe project from the fx dialog in the Libs project. I’ll have to see.

I also thought of having the diagram image popup when you hover over a measurement number. Wouldn’t require any addional buttons or space in the dialog.

2 Likes

Thank you so much!

1 Like

Ok, leave it at the 750px. At least one can read everything.

That would also be amazing. Then it can actually be larger than the box that I thought of and will be better to see. Will we have a check box to turn that feature on & off?

1 Like

I did some checking and it seems like it shouldn’t be too much trouble to load a diagram image via HTML and set the hover tooltip. And yes I thought of adding a pref to show the image or not.

2 Likes

Considering how much narrower the actual numbers are than the title “Number,” might it not be better to abreviate: “Num,” or I actually prefer “#” but realize that kids these days don’t know that “#” is “number” when not being used as a “hash-tag”. On the other hand, I’m not certain it would save enough pixels to make a difference either.

:unicorn:

2 Likes

When will be able to see the change? I just updated to the latest version dated 1/3/25 and it’s not showing the number column.

2 Likes

It’ll only come through next Monday.

1 Like

That’s what I was thinking but just wanted to make sure :slightly_smiling_face:

2 Likes

I should have maybe been more specific… when I said “Done” I meant I got the feature working on a feature branch my local build. I have yet to upload the changes to Github to get merged with the main project.

Also based on Grace’s request I’m adding to the feature so that when you hover over a diagram number the image will popup. Hopefully it makes it into next Monday’s reelease. :slight_smile:

2 Likes

Hi, @Douglas

I see this still hasn’t been released. Is there a problem with it?

Well there was a problem trying to display the diagram images. It has to do with the way the apps are structured. There’s basically 3 main projects - Seamly2D, SeamlyMe, and Libs. Libs is shared between 2D and Me… in other words when the whole project is built it builds all 3 and links 2D with Libs, and Me with Libs. Problem is the diagram resource files are in the SeamlyMe module, while the Fx editor is in the Libs module of Seamly2D… which doesn’t have access to the SeamlyMe diagram resoucre files as SeamlyMe is not linked with Seamly2D.

So… after all kinds of attempts, and finally realizing what the problem is, what I’m going to do to solve the issue is move the diagram resources to the Libs->misc->share where all the other Libs resources are. That way 2D and Me should both have access to diagrams - without having to duplicate the images. I’m hoping to have it fixed for the coming weeks release.

It also made me think a lot of why Seamly2D and SeamlyMe are seperate apps to begin with. The way the project is structured now makes a lot of things way more complicated than need be. IMO there’s no good reason to have 2 seperate apps… other than to make it harder for other programmers to work with the code.

2 Likes

Oh, wow! I didn’t realize it. The images would be nice to see, but if they can’t, it’s ok.

On the other hand, having the resources in the common Libs will probably make the programming easier for the future.

Edit:

Isn’t this so that the measurements can be changed in the pattern?

Having started using Valentina on an at that time older computer, I assumed it was so that low end computers could handle it. Open Me, setup measurements, close ME, Open 2D, draft pattern. No need to take up bandwidth with one facet if all you need is the other. Especially since the notion that it would have 3D capability was still active.

Since then it seems that the focus has shifted away from both extreme accessibility & extreme capability (in favor of being a part of the workflow rather than the channel of the workflow,) in favor of properly crafting the codebase.

:unicorn:

1 Like

Yes… IMO the shared resources should all be in one place. I can’t begin to tell you how schizophrenic the project folder structure is.

That has nothing to do with the 2 apps being seperate.

Neither of the app is that large. Combined they don’t even top 15k. Plus you could chop off about 3K with the extra Libs lib between the 2. Just for giggles I opened Me and 2D and screen capped task manager… Me was waaay down the list of memory usage and even 2D (with a hefty pattern loaded) hardly makes a dent compared to Chrome, Atom, and Explorer… even Task manager is using more than twice as much mem.

Screenshot (605)

If you’re opening Me from 2D you’re using the bandwidth anyway. In fact you’re actually using more as there’s 2 Libs and the additional code to sync between the 2… which if it were one app you wouldn’t need to sync them as it would internally be in sync. Besides with C++ the classes are dynamic where memory is typically only used when an instance of a class is created, and freed when it goes out of scope and destroyed.

3 Likes